Skip to content

add pekko.http.server.enable-http2 config and deprecate preview settings #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 20, 2025
Merged

add pekko.http.server.enable-http2 config and deprecate preview settings #818

merged 5 commits into from
Oct 20, 2025

Conversation

@pjfanning
Copy link
Member

@pjfanning pjfanning commented Oct 3, 2025 •
edited
Loading

  • pekko.http.server.enable-http2 replaces pekko.http.server.preview.enable-http2 (but that old setting is still checked too)
  • if either pekko.http.server.enable-http2 or pekko.http.server.preview.enable-http2 is set to on, the HTTP/2 is enabled
  • aim would be to also backport this to 1.3.0
  • if this is backported to 1.3.0, it would probably make sense to follow up in main branch and remove the PreviewServerSettings class altogether - even if we do continue to support the config pekko.http.server.preview.enable-http2
  • see HTTP2 Server Preview #756

@pjfanning pjfanning marked this pull request as draft October 3, 2025 05:42
@pjfanning pjfanning added this to the 2.0.0 milestone Oct 3, 2025
@pjfanning pjfanning marked this pull request as ready for review October 7, 2025 19:08
@pjfanning pjfanning merged commit c64deeb into apache:main Oct 20, 2025
5 checks passed
@pjfanning pjfanning deleted the preview-settings branch October 20, 2025 11:11
pjfanning added a commit to pjfanning/incubator-pekko-http that referenced this pull request Oct 20, 2025
@pjfanning
add pekko.http.server.enable-http2 config and deprecate preview setti…
eaa0b20 
…ngs (apache#818)

* add pekko.http.server.enable-http2 config

* scalafmt

* mima

* scaladoc

* Update ServerSettingsSpec.scala
@pjfanning pjfanning mentioned this pull request Oct 20, 2025
Merged
pjfanning added a commit that referenced this pull request Oct 20, 2025
@pjfanning
add pekko.http.server.enable-http2 config and deprecate preview setti…
e6440cb 
…ngs (#818) (#847)

* add pekko.http.server.enable-http2 config

* scalafmt

* mima

* scaladoc

* Update ServerSettingsSpec.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@He-Pin He-Pin He-Pin approved these changes

@mdedetrich mdedetrich Awaiting requested review from mdedetrich

@raboof raboof Awaiting requested review from raboof

@nvollmar nvollmar Awaiting requested review from nvollmar

@samueleresca samueleresca Awaiting requested review from samueleresca

@jrudolph jrudolph Awaiting requested review from jrudolph

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@pjfanning @He-Pin